lucianobroussal / gwtwindowmanager

Automatically exported from code.google.com/p/gwtwindowmanager
0 stars 0 forks source link

Windows don't disappear on Safari for Windows. #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Download Safari 3.0 for Windows from Apple.com 
2. goto http://www.gwtwindowmanager.org/
3. close a window and the blue box will remain.

Please provide any additional information below.

I'm not sure if this affects gwm on Mac Safari 3.0 as I don't have a Mac.

-Jeff

Original issue reported on code.google.com by jdw...@gmail.com on 12 Jun 2007 at 2:03

GoogleCodeExporter commented 8 years ago
It seems that:
outLine.setVisible(true);
Effects.Effect("BlindUp", outLine,"{duration : 0.6, scaleFromCenter: true}").

doesn't suceed in calling outLine.setVisible(false) on Safari. Here's a fix, 
you 
could do a 1-liner, but I've made other modifications to gwm so that it doesn't 
use 
the Effects. 

GFrame.java
    public void close() {       
        selectBoxManager.setBlockerVisible(false);

        setVisible(false);

        if(isEffects()){
             outLine.setSize(getWidth() + "px", getHeight() + "px");
             outLine.setDeep(layerOfTheTopWindow + 50);
             if (this instanceof GInternalFrame) {
                 ((GInternalFrame) this).getDesktopPane().addWidget(outLine,
                         0, 0);
             } else {
                 RootPanel.get().add(outLine);
             }

            outLine.setTop(top);
            outLine.setLeft(left);
            outLine.setVisible(true);
            Effects.Effect("BlindUp", outLine,
            "{duration : 0.6, scaleFromCenter: true}").addEffectListener(
                    new Effects.EffectListenerAdapter() {
                        public void onAfterFinish(Effect sender) {
                            closeCallback();
                            outLine.setVisible(false);
                        }
                    });
        }else{
            closeCallback();
        }
    }
    private void closeCallback(){
        removeFromParent();                 
        outLine.removeFromParent();
        selectBoxManager.removeBlocker();
        closed = true;
        if (modalMode) {
            overlayLayer.hide();
        }
        fireFrameClosed();
    }

Original comment by jdw...@gmail.com on 28 Jun 2007 at 3:25

GoogleCodeExporter commented 8 years ago
The window close effect leaves a ghosted window open on both Windows and Mac 
Safari.
The window should go away as it does on IE and FF.

Original comment by willi...@gmail.com on 2 Jul 2007 at 8:13

GoogleCodeExporter commented 8 years ago
Done

Original comment by luciano.broussal@gmail.com on 22 Aug 2007 at 5:03

GoogleCodeExporter commented 8 years ago
Adapted the workaround and tested with Safari 3.0 on Mac. Should be fixed with 
the
next release 

Original comment by Dominik.J.Steiner@gmail.com on 5 Nov 2007 at 6:56