search

lucianodato / noise-repellent

Lv2 suite of plugins for broadband noise reduction
GNU Lesser General Public License v3.0
463 stars 39 forks source link

ninja installs to /usr/local/nrepel.lv2 #57

Closed borgdylan closed 6 years ago

borgdylan commented 6 years ago

When updating the plugin, I noticed the switch to meson. After runnign meson and ninja to build, I noticed that ninja was not installing like make used to i.e. to /usr/local/lib/lv2/nrepel.lv2. I think teh new install locatin is outside the lv2 probing location.

lucianodato commented 6 years ago

You'll have to pass a prefix as explained in README.

borgdylan commented 6 years ago

Thanks. It would be nice to have a makefile that wraps meson and ninja.

lucianodato commented 6 years ago

Maybe a bash script. I used to have one but somehow I removed it. I could re-add it if you like.

borgdylan commented 6 years ago

That would be nice. The meson/ninja combiantion is new to peole not working on GNOME, and a script for building would help out. Most people are used to make/auto-tools which usually get configured with the right prefixes from the start.

lucianodato commented 6 years ago

As far as I know meson is not gnome specific and lots of projects outside of gnome are migrating to it. Generally is way less headache prone to developers. In the case of this simple plugin it's not that different to autotools that's true. Anyways I will upload the install script during the week. Thanks for the suggestion.

lucianodato commented 6 years ago

I upload a build script and updated the readme. It automatically recognizes if you are on linux or macos. Feel free to close this if this satisfies you.

borgdylan commented 6 years ago

The script works as expected! Thank you.