search

lucianodato / speech-denoiser

A speech denoise lv2 plugin based on RNNoise library
GNU Lesser General Public License v3.0
285 stars 29 forks source link

Any way to get this to work on Mac? #14

Open ToxMox opened 5 years ago

ToxMox commented 5 years ago

I'm thinking about moving to a Mac for my audio processing but I really need a plugin for RNNoise to bring with me. Is there a way I can use this in a DAW on Mac?

lucianodato commented 5 years ago

totally possible. In fact my travis ci script is already building for mac os and I did tried it on a mac when i had one

ToxMox commented 5 years ago

Oh cool! So if I follow the build and install instructions in the readme I should be good or should I do something different? Forgive me I'm not really familiar with compiling and working with Travis.

lucianodato commented 5 years ago

you have to install brew package manager and install all the dependencies. once that's done you can install using the last line of the readme. that would be something like:

brew update brew cask uninstall oclint brew install lv2 meson ninja pkg-config autoconf m4 libtool sudo chmod +x install.sh && sudo ./install.sh

ToxMox commented 5 years ago

Thank you! I will try this and report back next week when my new Mac arrives :)

lucianodato commented 5 years ago

Awesome! let me know if you encounter any problems

ToxMox commented 5 years ago

Got this error on the last step of actually installing the plugin: `Build started at 2018-11-19T19:43:20.405858 Main binary: /usr/local/opt/python/bin/python3.7 Python system: Darwin The Meson build system Version: 0.48.2 Source dir: /Users/toxmox/Downloads/speech-denoiser Build dir: /Users/toxmox/Downloads/speech-denoiser/build Build type: native build Project name: speech-denoiser Project version: undefined Sanity testing C compiler: cc Is cross compiler: False. Sanity check compiler command line: cc /Users/toxmox/Downloads/speech-denoiser/build/meson-private/sanitycheckc.c -o /Users/toxmox/Downloads/speech-denoiser/build/meson-private/sanitycheckc.exe Sanity check compile stdout:

Sanity check compile stderr:

Running test binary command: /Users/toxmox/Downloads/speech-denoiser/build/meson-private/sanitycheckc.exe Native C compiler: cc (clang 10.0.0 "Apple LLVM version 10.0.0 (clang-1000.10.44.4)") Build machine cpu family: x86_64 Build machine cpu: x86_64 Running compile: Working directory: /var/folders/td/y_y1c8_x62j3y1p07sdv99140000gn/T/tmpalcox3s1 Command line: cc /var/folders/td/y_y1c8_x62j3y1p07sdv99140000gn/T/tmpalcox3s1/testfile.c -pipe -c -o /var/folders/td/y_y1c8_x62j3y1p07sdv99140000gn/T/tmpalcox3s1/output.obj -O0 --print-search-dirs

Code:

Compiler stdout: programs: =/Library/Developer/CommandLineTools/usr/bin libraries: =/Library/Developer/CommandLineTools/usr/lib/clang/10.0.0

Compiler stderr:

meson.build:13:0: ERROR: C library 'rnnoise-nu' not found `

ToxMox commented 5 years ago

@lucianodato I've made sure meson is current because I read an earlier closed issue here that had a similar error and updating meson fixed it but not here. Running meson 0.48.2

In a feeble attempt to get it working I tried renaming rnnoise-nu.h to rnnnoise-nu but that didn't work because I don't know what I'm doing lol.

Any ideas?

lucianodato commented 5 years ago

hey, sorry for the delay. that error is because to compile the plugin you first need to compile a static version of rnnoise and you probably don't have the dependencies to compile it. look at the readme, it says what you need for that. right now, i don't remember the packages names for mac, but it should be something like "build-essentials". it's probably related to that. happy thanksgiving!

ToxMox commented 5 years ago

No worries. I tried to build rnnoise but got an error on the first step. I haven't found any references online to people compiling rnnoise on Mac so I kind of hit a brick wall.

Do you by any chance still have an old compiled Mac version laying around that I could use?

Here is the error and Happy Thanksgiving to you too! :)

Mac-mini:rnnoise toxmox$ ./autogen.sh Updating build configuration files for rnnoise, please wait.... Can't exec "aclocal": No such file or directory at /usr/local/Cellar/autoconf/2.69/share/autoconf/Autom4te/FileUtils.pm line 326. autoreconf: failed to run aclocal: No such file or directory

lucianodato commented 5 years ago

there is one available in travis ci server. i definitely need to learn how to download those and share them. i will do that asap

ToxMox commented 5 years ago

That would be amazing, thanks! You are a very kind developer and I appreciate you taking the time to help me 👍

ToxMox commented 5 years ago

@lucianodato ok so I got it to build. Needed brew install automake My problem now after some research is my VST host doesn't support LV2 files. FeelsBadMan. I tried building lv2vst using all the methods on this page http://www.admiralbumblebee.com/music/2017/11/29/Run-LV2-plugins-on-macOS.html and keep getting an error on the brew install lv2vst step. I hope some day you maybe you consider adding a mac vst or AU plugin to the build system if possible.

Error log: https://pastebin.com/h2rNg5p8 I'm also going to report this error on that page I linked but figured I'd update here too.

ToxMox commented 5 years ago

Ok so until I can get lv2vst wrapper working I'm using Ardour on Mac to use the plugin successfully.

My only question is I read there are 6 models to choose from but I don't see anywhere in the plugin window to change the model etc. Am I missing something simple here?

There is a preset dropdown with (none) as the only option. Is there supposed to be something there?

ToxMox commented 5 years ago

Ok so I received a new Makefile for lv2vst (should get fixed upstream by the dev soon for Mojave) that allowed me to build that as well. I am now successfully using the plugin in my VST host on Mac 👍

Now that I have it in my usual host I see the only setting is the reduction db in the interface. Is that correct?

lucianodato commented 5 years ago

that's great news. though your request is valid and i have previously been asked for the same. sometime in the future i will do it

lucianodato commented 5 years ago

regarding your question about the only parameter that you are able to see, yeah i haven't implemented model switching yet. the reduction though is enough with this one since rnnoise uses ML you don't need to tune anything else. works like magic!

MichelDiz commented 4 years ago

Not working on Catalina.

Build type: native build
Project name: speech-denoiser
Project version: undefined
C compiler for the host machine: cc (clang 11.0.3 "Apple clang version 11.0.3 (clang-1103.0.32.62)")
C linker for the host machine: cc ld64 556.6
Host machine cpu family: x86_64
Host machine cpu: x86_64
Library rnnoise-nu found: YES
Library m found: YES
Found pkg-config: /opt/local/bin/pkg-config (0.29.2)
Found CMake: /opt/local/bin/cmake (3.16.5)
Run-time dependency lv2 found: NO (tried pkgconfig, framework and cmake)

meson.build:18:0: ERROR: Dependency "lv2" not found, tried pkgconfig, framework and cmake

A full log can be found at /Users/user/speech-denoiser/build/meson-logs/meson-log.txt
ninja: error: loading 'build.ninja': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory
whicks1 commented 3 years ago

For me, this answer got me most of the way there on Catalina: https://stackoverflow.com/a/59808919/1660678 but I still had a FAILED: meson-install Permission denied: '/Library/Audio/Plug-Ins/LV2' changed INSTALL_DIR_MAC in install.sh to~/Library/Audio/Plug-Ins/LV2 and install sailed through.