search

lucianodato / speech-denoiser

A speech denoise lv2 plugin based on RNNoise library
GNU Lesser General Public License v3.0
287 stars 29 forks source link

Git Submodules? #2

Closed stefano-tronci closed 6 years ago

stefano-tronci commented 6 years ago

Hi! While lurking around in the code I had a look at static_rnnoise.sh. I see that you clone rnnoise there. I was just wondering whether you considered using a Git Submodule instead. Just a thought.

lucianodato commented 6 years ago

I was considering this option but I didn't had the time yet to look into it. Makes sense completely.

lucianodato commented 6 years ago

Thanks for your collaboration. I consider this done now.

dvzrv commented 6 years ago

sorry to necrobump: you'll need to manually include the submodule in a release tarball, as github won't do that. Another way of achieving the same is using git subtree merging.