search

lucianodato / speech-denoiser

A speech denoise lv2 plugin based on RNNoise library
GNU Lesser General Public License v3.0
285 stars 29 forks source link

Submodule and few changes to help packaging #8

Closed stefano-tronci closed 6 years ago

stefano-tronci commented 6 years ago

Hi! The latest changes introduced in the install script make the software hard to package for Arch Linux, as PKGBUILD mandate to have build and installation done in two separate steps, in directories that differ from the standard you provide. As such, your install script has to be bypassed.

To make things even easier, and address this issue, I also introduced the rnnoise dependency as a submodule. Currently, my AUR package is building from my fork as I find it more convenient.

As for installation script editing, I just did the bare minimal to make possible for an user to install from the fork by using it. I have no idea about how to use meson, but I have the feeling that it should be possible to have meson handling the build of rnnoise, and perhaps that would be the best option, so that meson/ninja can be used directly both from users and packagers with the same ease.

lucianodato commented 6 years ago

That install script shouldn't break what you had previously done for the aur package. It's just an install script for those users that doesn't know how to compile with meson. I'll have a look and let you know. As for the submodule that's great!

lucianodato commented 6 years ago

Ok. My bad. I removed the script for static rnnoise building. With that you shouldn't change your pkgbuild file I believe. I will re-upload it. Can you revise your pull request once that is done? It might be not necessary for you to keep your own repo that way. Besides this is as far as I will go to help users with the installing. No more changes in that regard.

stefano-tronci commented 6 years ago

Hi! I rebased the pull request on your latest changes. I edited the scripts a little. I think the comments should be easy to read.

lucianodato commented 6 years ago

Thank you!

stefano-tronci commented 6 years ago

Nice one! You might want to edit back the README file. In my fork I had the url of the installing instructions pointing to my repo.