search

lucianopaz / compress_pickle

Standard python pickle, thinly wrapped with standard compression libraries
MIT License
41 stars 10 forks source link

Missing string interpolation. #30

Closed jenstroeger closed 2 years ago

jenstroeger commented 3 years ago

This line here:

https://github.com/lucianopaz/compress_pickle/blob/a15a6e88b42fd52c0ec84c19303808b2a7f1b8f6/compress_pickle/compressers/registry.py#L56

is missing the f"" and thus yields

  File "/.../python3.7/site-packages/compress_pickle/compressers/registry.py", line 55, in get_compresser
    f"Unknown compresser {compression}. "
ValueError: Unknown compresser zip. Available values are {list(cls._compresser_registry)}
jenstroeger commented 3 years ago

But then I get

ValueError: Unknown compresser zip. Available values are [None, 'pickle', 'gzip', 'bz2', 'lzma', 'zipfile', 'lz4']

although I never installed the lz4 package. It might make sense to not register/list lz4 at all if it’s not available?