lucianopaz / compress_pickle

Standard python pickle, thinly wrapped with standard compression libraries
MIT License
42 stars 11 forks source link

Minor fixes for messages #42

Closed eode closed 2 years ago

eode commented 2 years ago

This includes some small fixes, such as a missing 'f' for an f-string, quoting strings in error output for clarity, and the like.

Examples:

Exceptions:

Different project leaders prefer different PR styles. If you find it acceptable, I'll just include these kinds of changes in with my other, code-related PRs. If you'd rather, though, I can keep spelling/message PRs separate from code PRs, as I have this one. Please inform!

codecov[bot] commented 2 years ago

Codecov Report

Merging #42 (67e7364) into master (8c3493b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          455       455           
=========================================
  Hits           455       455           
Impacted Files Coverage Δ
compress_pickle/compressers/registry.py 100.00% <ø> (ø)
compress_pickle/picklers/registry.py 100.00% <ø> (ø)
eode commented 2 years ago

Note that I've also updated requirements-dev.txt to include cloudpickle and dill, as some tests fail without them. Just mentioning that explicitly in case it's not what you want.

eode commented 2 years ago

This is ready, as far as I'm concerned.