search

lucid-fox / social-magick

An Open Graph Image generator plugin for Joomla 3 and 4
GNU General Public License v3.0
15 stars 1 forks source link

Update en-GB.plg_system_socialmagick.ini #20

Closed brianteeman closed 3 years ago

brianteeman commented 3 years ago

Remove some classes that are not present in the J3 admin template. Changes some formatting Changes the text "Set it by running" to "set it by including"

Before

image

After

image

nikosdion commented 3 years ago

I am rejecting this PR because of the reasons explained in gh-19. Further to that, we believe that "running" is the correct verb in the context: you are executing code. "Including" is misleading in this context because it would leads people to believe that including some magic text in a template override (as in: in the HTML output) would have the desired effect.

brianteeman commented 3 years ago

Including" is misleading in this context because it would leads people to believe that including some magic text in a template override (as in: in the HTML output) would have the desired effect.

If you do not mean that they should include that text in the override then what do you mean.

nikosdion commented 3 years ago

Include in the PHP part of the template override, not the HTML output part of the template override. “Run” is more appropriate in context than “include”. You can include any text anywhere. You can only run code (you can't “run” HTML or plain text).