lucid-fox / social-magick

An Open Graph Image generator plugin for Joomla 3 and 4
GNU General Public License v3.0
15 stars 1 forks source link

error on Acymailing front-end newsletters when having SocialMagick installed #34

Closed woluweb closed 2 years ago

woluweb commented 2 years ago

Steps to reproduce the issue

Expected result

No error

Actual result

Getting the following error: LucidFox\SocialMagick\ParametersRetriever::getCategoryArticleParameters(): Argument #1 ($id) must be of type int, null given, called in /home/festivalki/dev/plugins/system/socialmagick/library/ParametersRetriever.php on line 180

Troubleshooting already performed

When adding &format=raw to the url (which is actually the url that you get when clicking on the "read in my browser" link in the newsletter itself), then only the Newsletter is shown without any of the Joomla stuff (Menu, ...) and so there is no error message.

So to give an example:

I don't know if the issue is only with Acymailing for example or if it would occur for any third-party component (which does not have the Category ID or Item ID like for articles.

I wanted to disable SocialMagick on the Newsletter Menu Item, but the first switch only allows to choose between

As a quick workaround for this issue I have installed ReReplacer and I replace ´?tmpl=raw by ?tmpl=raw&format=raw (so that my end users can test the development website)

System information

Other Comments

Txs :) And of course I'll be happy to test any fix as usual.

woluweb commented 2 years ago

Once again txs a lot Crystal & Nicholas for the bug fixes and for the new release. I do confirm:

  1. no crash any more on Acymailing's page
  2. about the og image : the article image does now indeed appear behind the mask So everything solved :) Txs again, Marc
woluweb commented 2 years ago

Just a little feedback :

  1. even after downloading & upgrading manually from 1.0.0.b4 to 1.0.1, the website keeps telling that the update is available. So maybe the version was not updated in the zip ?

  2. when I use Joomla's update manager to update, I get the following error: Failed to download package. Download it and install manually from https://github.com/lucid-fox/social-magick/releases/1.0.1/socialmagick-1.0.1.zip.

and indeed that link gives a "not found"

nikosdion commented 2 years ago

Go to extension updates and click on the reset cache button. The update should work correctly now. Installing it will fix the problem with the update being continuously found.