lucide-icons / lucide

Beautiful & consistent icon toolkit made by the community. Open-source project and a fork of Feather Icons.
https://lucide.dev
ISC License
8.94k stars 380 forks source link

fix(icons): redesigned `home` icon #2116

Open jguddas opened 2 weeks ago

jguddas commented 2 weeks ago

What is the purpose of this pull request?

Description

Redesigned home icon

Before Submitting

github-actions[bot] commented 2 weeks ago

Added or changed icons

icons/home.svg
Preview cohesion icons/message-square-share.svg
icons/home.svg
icons/ferris-wheel.svg
Preview stroke widths icons/home.svg
icons/home.svg
icons/home.svg
DPI Preview (24px) icons/home.svg
Icon X-rays icons/home.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HomeIcon = createLucideIcon('Home', [
  ["path",{"d":"M15 21v-8a1 1 0 0 0-1-1h-4a1 1 0 0 0-1 1v8"}],
  ["path",{"d":"M3 10a2 2 0 0 1 .709-1.528l7-5.999a2 2 0 0 1 2.582 0l7 5.999A2 2 0 0 1 21 10v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z"}]
])

jguddas commented 2 weeks ago

What makes the curved door feel weird to you @karsa-mistmere? Looks pretty neat at 12x to me. Frame

karsa-mistmere commented 2 weeks ago

Also up for discussion: should we rename this to house?

karsa-mistmere commented 2 weeks ago

What makes the curved door feel weird to you @karsa-mistmere? Looks pretty neat at 12x to me. Frame

To me that looks awful, I very much prefer the right one:

image


Edit: I know now why exactly this is bugging me – adding rounding that's invisible at our default settings means that scaled/light icons are fundamentally different, I think this is definitely undesirable.

ericfennis commented 2 weeks ago

Can we also take a look at #1841 before we merge this one.

Other related issues:

karsa-mistmere commented 2 weeks ago

Can we also take a look at #1841 before we merge this one.

Other related issues:

@jguddas already designed this very cute icon at #2123 for the autarky use case

As for home-plus (or should it not be house-plus?), I think these are our best candidates: image

None of them spark joy, but it should definitely not be the last one.

jguddas commented 2 weeks ago

Can we also take a look at #1841 before we merge this one. Other related issues:

@jguddas already designed this very cute icon at #2123 for the autarky use case

As for home-plus (or should it not be house-plus?), I think these are our best candidates: image

None of them spark joy, but it should definitely not be the last one.

The second one with the plus in the roof looks nice.