Open locness3 opened 3 years ago
I agree
I agree, maybe we can move the current brand icons to a separate repo. I can imagine people want to use it
@locness3 @delnyn What about the idea, to create a separate package in packges folder called: 'lucide-brands'. We can move all the brand icons to this separate package, if people like to have this type of brand icons they can use the package. In the readme we can notice that the brand icons are deprecated and we don't update/maintain them.
Oh yes! Should I clone this one and remove the icons?
I don't know, but I think it'd be best if people didn't use them.
How about create deprecated section for icons instead of completely removing them?
Just for the record, this is/was also a concern in the Feather project, where is stated that
simple-icons/simple-icons repository already covers everything, uses SVG and the same 24x24
viewBox
, so it could be a great replacement for people that need brand icons.
Agreed.
soooo? we just delete them all?
I'm thinking of defining the ultimate v1.0 for Lucide and I think this should be a part of it.
what do you mean by "defining the ultimate v1.0 for Lucide"?
We are going with a lot of requests to add icons. I'm think split project. Part for medical, part for programing, part for brand , ... . In this case, 'quality, version, update, ...' of each package are different. In angular, we can one project for handle of use multi package icon library.
I don't understand lol
what do you mean by "defining the ultimate v1.0 for Lucide"? @delnyn I will create a separate discussion for that later. I need write down some points for that.
@SMAH1 Hmm I'm not fan of this idea. I think it wil add some unnecessary complexity. And can be really confusion as well.
Yeah, I agree, and apart from adding a layer of unnecessary complexity, this would introduce the problem of having to deal with icons overlapping multiple categories. Categorising icons sounds like a potentially useful feature, but it's partly accomplished already via tagging. I would maybe add very basic filtering on tags to the lucide.dev UI and make sure that icon categories are properly filled in within icon tags.
Edit: I have changed my mind about categories, see: #669
Hello guys,
If I can offer my 2 cents here, I do think it's fine to just remove them all-together. There are other alternatives so it's fine, there's no need to overcomplicate things just for some existing icons.
if I may chime in, I agree. They should be removed, maybe moved to a seperate lucide-brands
or depreciated repository--where people would be able to add more brand icons, if they wanted. But they wouldn't be part of the main lucide.
Especially since, due to lucides design guidelines, it's hard to accurately represent the logos while keeping them both recigniseable, good looking, and representative of the logo.
yeah I think everyone agrees. this issue is literally older than my brother, please someone remove the brand icons
Interesting
I think this is something we should do for lucide 1.0 and create a separate package, like @tryoxiss mentions.
From what I understand, these brand icons were removed, and the only way to get them now is to use simple-icons?
From what I understand, these brand icons were removed, and the only way to get them now is to use simple-icons?
@Sawtaytoes They haven’t actually been removed yet, but will be. In any case, I will be maintaining my own lucide-brands fork retaining them and some more…
I understand the logic for not adding any new brand icons, but I'd be against removing the current ones from the package. They fit in really well with the design language of the other icons, and make it easier for users to get started with just the single icon library.
From what I understand, these brand icons were removed, and the only way to get them now is to use simple-icons?
@Sawtaytoes They haven’t actually been removed yet, but will be. In any case, I will be maintaining my own lucide-brands fork retaining them and some more…
A lucide-brands package would be great. I want to keep using the same style for all the icons, but I need brand icons especially for social media stuff. If a new package emerges I will try to contribute.
@devlulcas They currently exist on the brands
branch of my fork here: https://github.com/danielbayley/lucide/commits/brands. I haven’t decided exactly what to do with them in a more canonical way, yet… There are also a growing number of icons from rejected PRs here, which also should live somewhere. Possibly something like lucide-brands
, and/or lucide-extra
[s
] packages… But need an easy way to hook into Lucide to add them to the fonts…
Since we don't add any brand icons, I think we should remove the current ones. What do you think?