search

lucidm / lcdi2c

Linux Kernel Module for HD44780 with I2C Expander
Other
21 stars 18 forks source link

Install from clean build fails: 'invalid argument' during install #5

Open Claudenw opened 4 years ago

Claudenw commented 4 years ago

I cloned the source from this repository onto a pi zero and build it there. I believe all prereqs are in place. The system responds with invalid argument but I don't see why. Any suggestions would be appreciated.

environment

clone and build

commands executed for clone are build are

git clone --depth 1 https://github.com/lucidm/lcdi2c.git /usr/src/lcdi2c-1.0.1
dkms add -m lcdi2c -v 1.0.1
dkms build -m lcdi2c -v 1.0.1
dkms install -m lcdi2c -v 1.0.1

The resulting output is

+ git clone --depth 1 https://github.com/lucidm/lcdi2c.git /usr/src/lcdi2c-1.0.1
Cloning into '/usr/src/lcdi2c-1.0.1'...
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 21 (delta 0), reused 12 (delta 0), pack-reused 0
Unpacking objects: 100% (21/21), done.
+ dkms add -m lcdi2c -v 1.0.1

Creating symlink /var/lib/dkms/lcdi2c/1.0.1/source ->
                 /usr/src/lcdi2c-1.0.1

DKMS: add completed.
+ dkms build -m lcdi2c -v 1.0.1

Kernel preparation unnecessary for this kernel.  Skipping...

Building module:
cleaning build area.............
make -j1 KERNELRELEASE=5.4.51+ -C /lib/modules/5.4.51+/build M=/var/lib/dkms/lcdi2c/1.0.1/build......................................
cleaning build area...........

DKMS: build completed.
+ dkms install -m lcdi2c -v 1.0.1

lcdi2c.ko:
Running module version sanity check.
modinfo: ERROR: Module /lib/modules/5.4.51+/lcdi2c.ko not found.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.4.51+/kernel/drivers/auxdisplay/

depmod.....
Job for systemd-modules-load.service failed because the control process exited with error code.
See "systemctl status systemd-modules-load.service" and "journalctl -xe" for details.

systemctl status systemd-modules-load.service

● systemd-modules-load.service - Load Kernel Modules
   Loaded: loaded (/lib/systemd/system/systemd-modules-load.service; static; vendor preset: enabled)
   Active: failed (Result: exit-code) since Sun 2020-07-26 10:02:55 BST; 7min ago
     Docs: man:systemd-modules-load.service(8)
           man:modules-load.d(5)
  Process: 22756 ExecStart=/lib/systemd/systemd-modules-load (code=exited, status=1/FAILURE)
 Main PID: 22756 (code=exited, status=1/FAILURE)

Jul 26 10:02:54 xxxxxxxx systemd[1]: Starting Load Kernel Modules...
Jul 26 10:02:55 xxxxxxxx systemd-modules-load[22756]: Failed to insert module 'lcdi2c': Invalid argument
Jul 26 10:02:55 xxxxxxxx systemd[1]: systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
Jul 26 10:02:55 xxxxxxxx systemd[1]: systemd-modules-load.service: Failed with result 'exit-code'.
Jul 26 10:02:55 xxxxxxxx systemd[1]: Failed to start Load Kernel Modules.

journalctl -xe

Jul 26 10:02:54 xxxxxxxx systemd[1]: Starting Load Kernel Modules...
-- Subject: A start job for unit systemd-modules-load.service has begun execution
-- Defined-By: systemd
-- Support: https://www.debian.org/support
-- 
-- A start job for unit systemd-modules-load.service has begun execution.
-- 
-- The job identifier is 1130.
Jul 26 10:02:55 xxxxxxxx systemd-modules-load[22756]: Failed to insert module 'lcdi2c': Invalid argument
Jul 26 10:02:55 xxxxxxxx systemd[1]: systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
-- Subject: Unit process exited
-- Defined-By: systemd
-- Support: https://www.debian.org/support
-- 
-- An ExecStart= process belonging to unit systemd-modules-load.service has exited.
-- 
-- The process' exit code is 'exited' and its exit status is 1.
Jul 26 10:02:55 xxxxxxxx systemd[1]: systemd-modules-load.service: Failed with result 'exit-code'.
-- Subject: Unit failed
-- Defined-By: systemd
-- Support: https://www.debian.org/support
-- 
-- The unit systemd-modules-load.service has entered the 'failed' state with result 'exit-code'.
Jul 26 10:02:55 xxxxxxxx systemd[1]: Failed to start Load Kernel Modules.
-- Subject: A start job for unit systemd-modules-load.service has failed
-- Defined-By: systemd
-- Support: https://www.debian.org/support
-- 
-- A start job for unit systemd-modules-load.service has finished with a failure.
-- 
-- The job identifier is 1130 and the job result is failed.
Jul 26 10:02:56 xxxxxxxx sudo[21419]: pam_unix(sudo:session): session closed for user root
lucidm commented 4 years ago

Hello, I didn't touch the code for a while and really not quite sure yet what's happening but no problem I can check it. Honestly, I didn't expect people will find this module usable, and maybe finally it's a good time to take the code and make it more robust. However, I wouldn't like to keep hollow promises I'll do it today or next week. BTW symptoms are very peculiar as not giving arguments should set them to the default. I also consider if removing default args wouldn't be better for the sake of code simplicity enforcing explicitness of module config.

Thank you for your feedback.