search

lucidnz / bootstrapify-1

An open-source base theme for Shopify using Twitter Bootstrap
http://bootstrapify-theme.myshopify.com/
187 stars 72 forks source link

Adding Slim for settings.html #169

Closed thomasdarde closed 10 years ago

thomasdarde commented 10 years ago

Hello,

Bootstrapify is great ! Nice work congrats. Sass is already a big win, and using slim could be to.

This PR is only for the settings.html wich is a full html file. I'll have to verify slim/liquid is working fine for the other files before converting them.

Are you interested in this PR ?

stewartknapman commented 10 years ago

Hey @thomasdarde, thanks. We have actually built a Shopify theme that generates the settings.html for us. Effectively each setting is a product. It's pretty sweet and we have been talking about open sourcing it.

Unless we converted our generator to output Slim at this point this pull request is going to complicate that workflow for us.

gavinballard commented 10 years ago

Hey @stewartknapman, I'd definitely be interested to learn more about how you're automatically generating settings.html files. I find they're a big pain point in Shopify themes and was thinking about putting something together to generate them from simple YAML files or something.

stewartknapman commented 10 years ago

Alright @gavinballard @thomasdarde and anyone else who's interested, I have put this up now: https://github.com/luciddesign/Shopify-theme-settings-generator

gavinballard commented 10 years ago

Thanks @stewartknapman!