search

lucidnz / bootstrapify-1

An open-source base theme for Shopify using Twitter Bootstrap
http://bootstrapify-theme.myshopify.com/
187 stars 72 forks source link

Checkout Styles Broken #185

Closed callaginn closed 10 years ago

callaginn commented 10 years ago

Mobile devices are now loading the default checkout styles, instead of your styles. These styles were loading a few days ago. Shopify support said there were no changes on their end...so I was wondering if it could be an issue with the theme or if you had any ideas.

In other words, checkout.css.liquid is completely ignored. This has been reproduced on both Android and Mobile. You can view my site here to reproduce the issue: http://supershakes-3.myshopify.com/

I'm using Bootstrapify 3.1.1 and the default version of your checkout.css.liquid file.

iphone5 motox

stewartknapman commented 10 years ago

I'm not sure how the standard checkout styles were displaying on mobile as the mobile checkout uses a different style sheet to the standard checkout:

checkout.css.liquid for the standard checkout and checkout.mobile.css.liquid for mobiles.

see:

We have a checkout.mobile.css.liquid but it's currently empty and unused. https://github.com/luciddesign/bootstrapify/issues/57

callaginn commented 10 years ago

Mobile devices were previously loading the checkout styles from checkout.css.liquid. Everything was working great until today, when something changed on Shopify. Shopify was no help, so I was hoping you had some insight...or that other people had run into this issue.

gavinballard commented 10 years ago

@Callaginn, when the "default" checkout styles were loading, were you testing on a real mobile device or just with a resized browser window? Shopify uses User-Agent sniffing to serve the mobile styles rather than media queries so often that causes some confusion.

callaginn commented 10 years ago

I had tested it on both an iPhone 5, iPhone 5s, and a Moto X. Everything (as of a few days ago) looked fine. I was not aware that Shopify used User-Agent sniffing, since my media queries were working previously.

gavinballard commented 10 years ago

Ah, then I'm afraid I'm not sure sure what the problem was then sorry! In any case, I guess the behaviour you're seeing now is the expected behaviour as the mobile stylesheet for Bootstrapify is empty.