search

lucidnz / bootstrapify-1

An open-source base theme for Shopify using Twitter Bootstrap
http://bootstrapify-theme.myshopify.com/
187 stars 72 forks source link

Uniform Thumbnails is stretching images #196

Closed darryn closed 10 years ago

darryn commented 10 years ago

When 'thumbnails cropped' is activated in the theme settings landscape images are stretched to the full height of the container (based on the thumbnail ratio of 2:3).

http://chateau.myshopify.com/collections/reece-hudson

But works fine when the image is square or portrait.

http://chateau.myshopify.com/collections/ba-sh-paris

When 'thumbnails cropped' is deactivated the landscape images are fine but the square/portrait images are stretched.

darryn commented 10 years ago

Update

The same issue applies to landscape thumbnail images of differing ratios:

http://chateau.myshopify.com/collections/accessories/Sunglasses

stewartknapman commented 10 years ago

Fixed with https://github.com/luciddesign/bootstrapify/commit/5d7e35849fe57b3176dea61e6cc52295d4cb3edc