search

lucidnz / bootstrapify-1

An open-source base theme for Shopify using Twitter Bootstrap
http://bootstrapify-theme.myshopify.com/
187 stars 72 forks source link

Fix pagination issues with multi-page search results #207

Closed galenking closed 9 years ago

galenking commented 9 years ago

Apparently clicking beyond page 1 of search results does nothing—see http://www.gearshop.co.nz/search?q=waist

ajmalafif commented 9 years ago

Hello all, I'm able to replicate this bug too. Any guide or pointer how I can help to squash this?

ajmalafif commented 9 years ago

Found a quick fix: https://github.com/ajmalafif/bootstrapify/commit/4d61a2770401d29905074175b272f7c76f105cf5

Live example (of the fix): http://www.majordrop.com/search?q=grand

stewartknapman commented 9 years ago

@ajmalafif thanks for the heads up on this.

Turns out that accessing search.results.size kills the pagination.

ajmalafif commented 9 years ago

@stewartknapman it's the least I can do to be honest! Major and many many thanks for this awesome repo and support you all have here!