search

lucidnz / bootstrapify-1

An open-source base theme for Shopify using Twitter Bootstrap
http://bootstrapify-theme.myshopify.com/
187 stars 72 forks source link

Collection title out of container #215

Closed adler99 closed 9 years ago

adler99 commented 9 years ago

Title of collection appears on the very left side of view port. It should be within the container limits. I guess it is because in collection-page.liquid the collection-header is included before the container-open includes. Cool template! Thanks for the good work!

stewartknapman commented 9 years ago

Hi @adler99,

Do you have an example where this is broken?

adler99 commented 9 years ago

Unfortunatly not, just a screenshot. And its the heading defined in collection-header.liquid line 6

I have attached a screenshot: collection_title

stewartknapman commented 9 years ago

@adler99 I believe this has been fixed now, but can you confirm that this is no longer an issue?

adler99 commented 9 years ago

Sorry stewartknapman, but my template is modified in many places, I can not install the new version and check if its locking all right... how do you test that stuff? Having an extra shopify account for testing?

stewartknapman commented 9 years ago

@adler99 we are Shopify partners (http://www.shopify.com/partners) so we have access to create as many development stores as we need for working with. If you're working with Shopify a lot then I suggest you sign up to be a partner.

Also as far as upgrading the theme goes, you should just be able to do a git pull. You might end up with some conflicts, but they should be easy enough to work through. That way you'll get the benefit of bug fixes, etc.