Closed ajmalafif closed 9 years ago
@ajmalafif I have the same issue! Just noticed it today. I've been looking for 3 hours! I'll do the same.
@ajmalafif Potentially the commit by @Shopify as shown here? https://github.com/Shopify/liquid/commit/9c9345869bfc69894fad500347656cd8ecd95306
Potentially the commit by Shopify as shown here? Shopify/liquid@9c93458
That hasn't been deployed to Shopify yet, and doesn't seem relevant to your error.
cc @pushrax this could be related to pull request https://github.com/Shopify/liquid/pull/616
@dylanahsmith thanks for the correction.
The key difference is that non-integers are converted to integers using Integer(input.to_s)
instead of input.to_i
so perhaps you are trying to use nil
as part of a range.
@MicrobrewMedia
Ouch! So far I'm dumbfounded for like 1 hour. Hopefully one of us found a solution soon!
It looks like you are doing things like {% for i in (i..5) %}
which looks suspect (https://github.com/luciddesign/bootstrapify/blob/63e7492f4660bb0dad2ffde26b1b3be2b0a7feed/theme/assets/_base.scss.liquid#L9305). I'm guessing i
hasn't been assigned a value before lines like that.
git grep -n '{% for i in (i..'
dist/scss/bootstrapify_overrides.scss.liquid:1058:{% for i in (i..5) %}
theme/assets/_base.scss.liquid:9305:{% for i in (i..5) %}
theme/assets/_settings.scss.liquid:92:{% for i in (i..5) %}
theme/snippets/footer.liquid:5: {% for i in (i..3) %}
theme/snippets/slider-static-slider.liquid:1:{% for i in (i..4) %}
@dylanahsmith I can confirm I know I've seen those while making my site from this theme. Make sense why the SCSS.liquid is messed.
I wonder if @stewartknapman or @galenking can share how their site on Gearshop is living currently in regards to those files? Thanks!
Theoretically prior to this change, affected pages would have been getting a 500 error. (a Ruby NoMethodError
for to_i
instead of Liquid::ArgumentError
)
edit: actually, "asdf".to_i == 0
, but Integer("asdf") => ArgumentError
, that is probably the issue.
Fix is in Liquid here: https://github.com/Shopify/liquid/pull/620, this will go out in Shopify very soon. Sorry!
Everything should be good now, please let me know if you are still experiencing any errors.
@pushrax still dead on my end. Sent you an Email with site.
@MicrobrewMedia you probably have the page cached in your browser – I'm not seeing the error on your shop on my end. Try ctrl-shift-r or cmd-shift-r depending on your browser/os to refresh the page ignoring your cache.
Wait, so is everyone good now?
Yep, the issue has been fixed globally and Shopify's caches flushed. Any remaining cases would be because of local browser caches.
Still Getting on jones-golf-bags.myshopify.com... I've tried multiple Browsers and Cleared them and Gone Incognito ...
Cool, thanks @pushrax
Look good now. Seems Shopify was slowing moving over. Cheers!
I think what happened for you was that your error was in a CSS Liquid file, which is cached on our CDN differently than the storefront page cache. Sorry for any confusion.
No worries. Thanks Justin! Appreciate everyones help in this.
Ok cool, I'm at work now so I've had a chance to look into this properly, and yea those for loops were just plain whacky.
I've fixed them now.
Awesome.
hey all,
I'm getting
liquid error: invalid integer
on sliders. Could be Shopify's changing something to liquid and affecting it. Sitting through it, will share solution if i found first.Thanks.