search

lucidrains / alphafold2

To eventually become an unofficial Pytorch implementation / replication of Alphafold2, as details of the architecture get released
MIT License
1.57k stars 258 forks source link

OuterMean block's typo #86

Closed CiaoHe closed 3 years ago

CiaoHe commented 3 years ago

Hi, Luci: Here, the original paper uses outer-product, but here uses outer-sum https://github.com/lucidrains/alphafold2/blob/586792d738b9867d02b85a304c9b56091121b460/alphafold2_pytorch/alphafold2.py#L316

plz have a check, many thanks!

hypnopump commented 3 years ago

Hi there! Seems you've been taking a decent review at the code! I'd like to invite you to the discord server where the replication is being coordinated: https://discord.gg/NNGTt4Vp . Hopefully we can get this done soon!

lucidrains commented 3 years ago

@CiaoHe thank you, this is bug number 3 you've caught :) :pray:

lucidrains commented 3 years ago

fixed in latest

CiaoHe commented 3 years ago

Hi there! Seems you've been taking a decent review at the code! I'd like to invite you to the discord server where the replication is being coordinated: https://discord.gg/NNGTt4Vp . Hopefully we can get this done soon!

Hi, thanks for invitation, I'm already in lol