Closed LWprogramming closed 1 year ago
@LWprogramming thank you! 🙏
so i used to keep the eos, and then taught the subsequent transformers to ignore the eos token. but it got to be too complicated, as i had to make sure the eos id is consistent across all wrappers, and do a bunch of self attention masking. so i redesigned it to simply remove the eos altogether
By the way, why is
keep_eos
hardcoded asFalse
in some places here? I searched through the blame and it used to useinclude_eos_in_output
but it seems like there was something about maybe the hierarchical part here