(Suggestion) `--open-folder` parameter should default to False

lucidrains / deep-daze

Simple command line tool for text to image generation using OpenAI's CLIP and Siren (Implicit neural representation network). Technique was originally created by https://twitter.com/advadnoun

MIT License

4.37k stars 327 forks source link

(Suggestion) `--open-folder` parameter should default to False #63

Closed afiaka87 closed 3 years ago

afiaka87 commented 3 years ago

I've been having trouble with this parameter as a default. I realize it is probably a nice feature when it works well, but on my current setup it just sort of messes with my window layout.

NotNANtoN commented 3 years ago

For me this also does not work and just throws warnings that xgdopen is not installed. If we want to create a new folder per experiment we should just use python's "os" module with os.makedirs and os.chdir. That's how I do it in my external wrapping script.

afiaka87 commented 3 years ago

@lucidrains I'm gonna close this in a few days. I know you're busy but I still think this is a reasonable default. At any rate, you're the maintainer so I'll defer to your judgement and take silence on the issue as disagreement. Not a big deal ultimately.