search

lucidrains / imagen-pytorch

Implementation of Imagen, Google's Text-to-Image Neural Network, in Pytorch
MIT License
8.11k stars 768 forks source link

improvement #373

Closed TheFusion21 closed 10 months ago

TheFusion21 commented 10 months ago
lucidrains commented 10 months ago

@TheFusion21 hey Kay! long time

thanks for the PR

only quibble i have is about the pydantic dep version

TheFusion21 commented 10 months ago

@lucidrains pydantic broke something when loading the cli created checkpoint after your change in this commit

can't seem to figure out why

lucidrains commented 10 months ago

@TheFusion21 ah, we should migrate everything to pydantic 2

what is the error that you see?

lucidrains commented 10 months ago

i'm sure you can figure it out, you're a developer!

lucidrains commented 10 months ago

@TheFusion21 if you can get a minimal script that reproduces the error, i'll sink a few hours and get it fixed

TheFusion21 commented 10 months ago

breaks here https://github.com/lucidrains/imagen-pytorch/blob/4451ab7025f24113feeab72e73a0be16f2ee9471/imagen_pytorch/configs.py#L68C37-L68C37

can get you a full stack trace later

Will dig into it

TheFusion21 commented 10 months ago

Hope you had a great holiday/vacation and happy new year ^^

lucidrains commented 10 months ago

@TheFusion21 you as well! happy new years!