search

lucidrains / reformer-pytorch

Reformer, the efficient Transformer, in Pytorch
MIT License
2.1k stars 254 forks source link

Update README.md #78

Closed Kyeongpil closed 4 years ago

Kyeongpil commented 4 years ago

I think enc_input_mask is not correct because there is no enc_input_mask argument. I think enc_input_mask should be replaced to input_attn_mask.

lucidrains commented 4 years ago

@rudvlf0413 oh, I believe it is correct. I actually namespace both the encoder and decoder keyword arguments with enc_ and dec_ using https://github.com/lucidrains/reformer-pytorch/blob/master/reformer_pytorch/reformer_enc_dec.py#L28

Kyeongpil commented 4 years ago

@lucidrains Oh, I see. I think it is difficult to understand what arguments are passed to each function. How about describing these arguments in the document or README?