Is 'broadcat' part of the API?

[rsxdalv]

With the latest versions broadcat function is no longer available to import; however, projects like tortoise depend on this import. Should this import have been private, and not part of the public API?

[lucidrains]

@rsxdalv oh oops! no idea it was being used, and in such a high profile project!

in a later commit, i discovered broadcast_tensors and that function got reduced down to 3 loc

from torch import broadcast_tensors

def broadcat(tensors, dim = -1):
    broadcasted_tensors = broadcast_tensors(*tensors)
    return torch.cat(broadcasted_tensors, dim = dim)

[rsxdalv]

Actually I discovered that it's being imported but not being used; I didn't realize this at first as I'm a downstream project from tortoise.

Thank you for the quick response.

[rsxdalv]

So, in the scope of tortoise project, this issue can be closed.

[lucidrains]

@rsxdalv got it, yea, i brought it back just to save you the trouble

[rsxdalv]

Thank you, that will fix my project's installation!