Closed AliYoussef97 closed 2 months ago
Hello,
Thank you for the amazing work!
I had a brief question, shouldn't (n r) in repeat be (r n) here. As (r n)!=(n r), as (r n) would be equivalent to freqs = torch.cat((freqs, freqs), dim=-1). I might be compeltely wrong though, and order does not matter.
(n r)
(r n)
freqs = torch.cat((freqs, freqs), dim=-1)
Thank you!
Hello,
Thank you for the amazing work!
I had a brief question, shouldn't
(n r)in repeat be(r n)here. As (r n)!=(n r), as(r n)would be equivalent tofreqs = torch.cat((freqs, freqs), dim=-1). I might be compeltely wrong though, and order does not matter.Thank you!