search

lucidrains / vector-quantize-pytorch

Vector (and Scalar) Quantization, in Pytorch
MIT License
2.44k stars 197 forks source link

Modernizing the setup #119

Closed MisterBourbaki closed 5 months ago

MisterBourbaki commented 5 months ago

It would be great to upgrade the setup.py file, as it is quite old-fashioned :) As it is indicated here for instance.

I could open a dedicated PR if you'd like @lucidrains !

lucidrains commented 5 months ago

@MisterBourbaki hey, thanks for the suggestion

could you let me know if the latest commit looks ok?

MisterBourbaki commented 5 months ago

That is a start :) I think you could put all that is in setup.py into pyproject.toml, in a single file.

I would also recommend the use of Poetry as a tool, but that is certainly another story.