search

lucidrains / voicebox-pytorch

Implementation of Voicebox, new SOTA Text-to-speech network from MetaAI, in Pytorch
MIT License
589 stars 49 forks source link

a mistake in rotary embbeding #13

Closed chenht2021 closed 1 year ago

chenht2021 commented 1 year ago

https://github.com/lucidrains/voicebox-pytorch/blob/47e31803db3ad8df93bf29a91007b4f45eba00fd/voicebox_pytorch/voicebox_pytorch.py#L236

fd873630 commented 1 year ago

I'm testing with a toy dataset.

The previous code was not trained.

Changing to this code seems to be training well from the first epoch.

Awesome! Thank you so much.