search

lucidsoftware / cumulus

Cloudformation alternative
http://lucidsoftware.github.io/cumulus/
Apache License 2.0
28 stars 6 forks source link

Everything registers as a diff in SQS #146

Closed msiebert closed 8 years ago

msiebert commented 8 years ago

This happened either as a result of upping the aws-sdk version or the type changes @mcrossen made. Looks like it's probably comparing ints to strings and "0" != 0 :(

msiebert commented 8 years ago

I think this might have actually been caught by the tests I've got in #141

mcrossen commented 8 years ago

k. I'm creating a pull request for this. I've tested the fix, and it works out well. Turns out, the aws sdk is to blame. The sdk is returning the string encoded integers. In the fix, I'm just converting the values back to integers.