lucidsoftware / piezo

Piezo is a set of tools for operating a quartz scheduling cluster.
Apache License 2.0
53 stars 28 forks source link

Adding monitoring priority to all triggers. #62

Closed jjudd closed 7 years ago

jjudd commented 7 years ago

Triggers now have an associated monitoring priority.

This priority is used to determine whether or not to send StatsD metrics for a trigger. It is persisted in the database and can be accessed via a model. Accordingly, it can be used for additional monitoring beyond the monitoring built into Piezo. For example, a monitoring job could be created and the priority used to determine whether an alert should be created, and what priority it should be when a trigger enters into an error state or fails to run.

gregghz commented 7 years ago

LGTM.

Maybe we should have peizo depend on relate to clean up / make the jdbc stuff a bit safer and more readable.

jjudd commented 7 years ago

Agreed. That and a real patch system for the db patches. Both are outside the scope of this PR, though.

disaacson commented 7 years ago

Looks good! Just the couple of noted tweaks.