Closed gregghz closed 7 years ago
FYI, there's a lot that could be cleaned up if we cared to.
InterruptedException
. Usually wrong to ignore it; it means someone wants to stop your thread.LGTM. Things could be improved, but this fixes the main problem. I suggest we merge this and then do any other improvement in other PR's.
@pauldraper most of those sound like misunderstandings. I can explain to you in person if you want. The pid file is used by startup/shutdown scripts. The exiting when stdin is closed mimics how play works. It does not eat up a CPU (misunderstanding about how semaphores work maybe?).
We use upstart to manager our quartz jobs. Upstart sends SIGTERM to stop the upstart job. Without this change, this terminates the jobs without calling scheduler.shutdown(true). I think this will fix the issues we have of triggers being set to run in the past. If not, it's still a more clean shutdown of quartz.