Don't send empty messages

lucidstack / ex-portmidi

Elixir bindings to the portmidi library

MIT License

35 stars 12 forks source link

Don't send empty messages #17

Open patmaddox opened 3 years ago

patmaddox commented 3 years ago

Fixes #16

patmaddox commented 3 years ago

It is easy enough for the client to look for [] events and ignore them - I thought it made more sense for the library to not send empty events at all though. What do you think?

patmaddox commented 3 years ago

Turns out this makes it less reliable - messages can stop getting sent after a while. I still think it probably doesn't make sense to send empty messages (I'm seeing thousands of empty messages at a time sometimes). I'm just not sure how to do that...

thbar commented 3 years ago

@patmaddox the "empty messages" problem seems to be fixed by #15. I will incorporate it into my own fork at https://github.com/thbar/ex-portmidi.