search

lucidworks / lucidworks-view

Create custom user experiences for your Fusion-powered apps.
https://lucidworks.com/view
Apache License 2.0
37 stars 23 forks source link

Add another signal option for more flexible data submission, fix a bu… #21

Closed gsingers closed 8 years ago

gsingers commented 8 years ago

Lays out a broader use for signals, also fixes a bug in the postSignal that wasn't bringing in the config properly

arijitdasgupta commented 8 years ago

@gsingers Added a proposed solution to the =bind bug, now it posts document IDs as well. But given the changes, I think this PR needs another review.

I was wondering why we need the bind=doc in documentList? @JoshEllinger

arijitdasgupta commented 8 years ago

Also I think we need to recreate this PR against develop. master I think it to be synced with the release all the time.

JoshEllinger commented 8 years ago

Without =bind I think there were issues with the directive not binding properly. I'd test different results to make sure signals still work and that the documents update properly on pagination @arijitdasgupta

arielisaacs commented 8 years ago

I'm going to close this PR and open a new one against the develop branch.