search

lucidworks / lucidworks-view

Create custom user experiences for your Fusion-powered apps.
https://lucidworks.com/view
Apache License 2.0
37 stars 23 forks source link

TI-153 Facet range directive #35

Closed JoshEllinger closed 8 years ago

JoshEllinger commented 8 years ago

recreated this pull request off of develop so it will be cleaner 🎱

TODO:

Right now it works with regular facets. In this PR, the limits in range facets are treated as regular strings.

We can probably do something smarter with those limits and show them more appropriately (e.g. dates, floating points etc) with slightly better borders e.g. (0 - 99, 100 - 199 ...). (TI-155)

But as of now, a user can use Query pipelines to do those manipulations.

arielisaacs commented 8 years ago

Just a note, this is a PR for visibility and need some work before it can be merged into the develop branch.

JoshEllinger commented 8 years ago

TODO: if i remember was to use query builder to work with range facets

arielisaacs commented 8 years ago

That's right. As well as cleaning up some of the earlier work and making it align more with the current implementation of facets.

arijitdasgupta commented 8 years ago

Oh we have a new PR now.

arijitdasgupta commented 8 years ago

@JoshEllinger this is ready for a first pass review.

arijitdasgupta commented 8 years ago

Doing some refactors and cleanup where-ever apt.

arijitdasgupta commented 8 years ago

Now using QueryBuilder as it's supposed to be used.

arijitdasgupta commented 8 years ago

Over to @JoshEllinger for review.

JoshEllinger commented 8 years ago

Tried standing this up with the following params. And was not able to get range queries to show up in view :( fusion my_new_app_name

Got it working, by having a field facet in addition to my range facet. So it looks like we need better checking of if there are range facets to know we have to show the filter panel

arijitdasgupta commented 8 years ago

Ah probably not behaving well with dates. Okay, will look into it.

arijitdasgupta commented 8 years ago

@JoshEllinger what did you mean by " by having another filter too." in your last comment?

arijitdasgupta commented 8 years ago

Looks lik in your stage configuration, you haven't set facet to true. That enabled faceting on Solr. Could you try adding that?

JoshEllinger commented 8 years ago

facet=true, is set now, it did not change how this worked. if you notice in the pictures, the facet is being returned. This is not a user error, but a View error

arijitdasgupta commented 8 years ago

Ah okay. Cool. yeah could be a problem with the date formats

arijitdasgupta commented 8 years ago

Okay I see it now. Fixing.

arijitdasgupta commented 8 years ago

@JoshEllinger fixed the problem with facet display. the problem was that showFacets were only being set in the presence of facet_fields. Fixed now. Back to you

arijitdasgupta commented 8 years ago

Made sure the facet model gets reset, that way update in the query pipeline won't require a full refresh of the page. But any reason why we did keep those facet data persistent across data loads?

JoshEllinger commented 8 years ago

So there wasn't a redraw flash on every new request

On Tuesday, May 17, 2016, Arijit Dasgupta notifications@github.com wrote:

Made sure the facet model gets reset, that way update in the query pipeline won't require a full refresh of the page. But any reason why we did keep those facet data persistent across data loads?

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/lucidworks/lucidworks-view/pull/35#issuecomment-219714551

arijitdasgupta commented 8 years ago

@JoshEllinger right thanks. So then we need a compare for resets. No need to reset all of them, but a compare of what's new.

JoshEllinger commented 8 years ago

That would be the preferred way, yeah :)

On Tuesday, May 17, 2016, Arijit Dasgupta notifications@github.com wrote:

@JoshEllinger https://github.com/JoshEllinger right thanks. So then we need a compare for resets. No need to reset all of them, but a compare of what's new.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/lucidworks/lucidworks-view/pull/35#issuecomment-219715137

arijitdasgupta commented 8 years ago

Got it. okay thanks.

arijitdasgupta commented 8 years ago

@JoshEllinger improved on the compare for facet display intelligent reflow routine

JoshEllinger commented 8 years ago

This looks awesome! ready to merge into develop

JoshEllinger commented 8 years ago

Squashed and merged into develop :)