search

lucidworks / lucidworks-view

Create custom user experiences for your Fusion-powered apps.
https://lucidworks.com/view
Apache License 2.0
37 stars 23 forks source link

Errors in IE for Object.assign, and then #38

Closed toddlack closed 8 years ago

toddlack commented 8 years ago

Thanks for releasing this app - it is very useful and educational! Our testers tried this in IE, and "it didn't work". I believe I have isolated the problems below. I realize this is most likely not your code that is having an issue, but I hope that maybe you all have seen it before and can help eliminate it. We do not have the option of not supporting IE. Thanks for any insight!

What is happening is the app is throwing an error when it hits the _Object.assign(Object.assign(query,hc.highlightdefaults) in the HomeController. I tried using es6-shim and another work-around from this gist (https://gist.github.com/WebReflection/10404826), which I added as client/assets/js/utils/Object.assign.js

This got through the Object.assign problem - but then it throws an error on what appears to be every result row: TypeError: Assignment to read-only properties is not allowed in strict mode at Anonymous function (http://localhost:3000/assets/js/foundation.js:35723:9) at fn.assign (http://localhost:3000/assets/js/foundation.js:35633:9) at parentValueWatch (http://localhost:3000/assets/js/foundation.js:30671:19) at oneTimeInterceptedExpression (http://localhost:3000/assets/js/foundation.js:36276:9) at oneTimeWatch (http://localhost:3000/assets/js/foundation.js:36209:9) at Scope.prototype.$digest (http://localhost:3000/assets/js/foundation.js:37715:21) at Scope.prototype.$apply (http://localhost:3000/assets/js/foundation.js:37988:13) at done (http://localhost:3000/assets/js/foundation.js:32373:36) at completeRequest (http://localhost:3000/assets/js/foundation.js:32571:7) at requestLoaded (http://localhost:3000/assets/js/foundation.js:32512:9)

toddlack commented 8 years ago

Perhaps I should use the latest code in Master, which does not have Object.assign. Sorry about that.

JoshEllinger commented 8 years ago

Briefly looked into the codebase, could not find object assign, glad you figured it out!

toddlack commented 8 years ago

After merging the entire Master branch with our customizations, the* TypeError: Assignment to read-only properties is not allowed in strict mode*

is also FIXED in this branch :-) Thank you!