SignalsService.postClickSignal should pass in position information

[janezomgzomg]

• New fields that will be passed in:
  • lw_url
  • position - position
  • page
  • head_field
  • language
  • platform
  • user_agent
  • user_name
• A scope variable position is passed down into the document directive from document-list. It returns the value of getDocPosition which returns the index of the document in the current document result list.
• Params passed into postSignal function are lw_url, position and page. The get appended to data.params in SignalsService.postClickSignal.
• added getNormalizedCurrentPage to PaginateService. The value of the current page number is normalized wrt 1.
• Params that will be added to SignalsService.postClickSignal are:
  • head_field
  • language
  • platform
  • user_agent
  • user_name
• Added ClientStatsService with the following functions:
  • getBrowserLanguage - returns language and locale of the browser
  • getBrowserPlatform - returns browser platform
  • getBrowserUserAgent - returns user agent
• Tiny fix: __signals_doc_id__ has been set with the value of doc.id

EDIT:

• some cleanup wrt postSignal in the controller of every doc type where the doc and lw_url will be passed in via the function call in the template
• position and page will be added to the options obj in the controller
• SignalService.postClickSignal will be called in the postSignal function in the controller with the required parameters
• this will ensure that the postSignal call in the template is readable.

[gsingers]

Should we just use Snowplow? I've got it pretty well abstracted at this point as an Angular service.

[JoshEllinger]

I thought snowplow has backend requirements? View is mostly frontend, and (mostly) deployable without a backend.

Is that not the case?

[gsingers]

It doesn't have backend requirements, @JoshEllinger. It's a slightly different endpoint, but still accessible.

[JoshEllinger]

think this looks great! passing to @arijitdasgupta for second review. Also the snowplow is in another issue, so as not to mess with the functionality here.

[arijitdasgupta]

Looks great. Works nicely.

Other than my previous comment on code about postSignal function implementation, this is ready to go. 👍

[janezomgzomg]

@arijitdasgupta I've gotten rid of the redundant doc in postSignal.

[arijitdasgupta]

💥 It's ready!