lucidworks / lucidworks-view

Create custom user experiences for your Fusion-powered apps.
https://lucidworks.com/view
Apache License 2.0
37 stars 23 forks source link

Implement multi select faceting #45

Closed janezomgzomg closed 8 years ago

janezomgzomg commented 8 years ago

PR created for visibility. This is currently implemented only in field facets.

Basics
JoshEllinger commented 8 years ago

@janezomgzomg looks great mostly, Could use more comments, and moving code around to make organization better. But overall looks great.

janezomgzomg commented 8 years ago

@JoshEllinger I've made the requested changes and added comments. I've updated the PR description.

JoshEllinger commented 8 years ago

I do have some ideas on how to make this code cleaner, and more scalable to other situations. But in interests of getting something in, i think this looks fine, as it works.

In the future, i think it makes more sense not to use localParams syntax at all outside of querybuilder, which should handle all syntax issues. Also appending tag in front of keys is probably an unnecessary constraint, and has the possibility affect some untested edge cases.

@janezomgzomg great job on a tough part of View and solr 🚀