search

luciotato / LiteScript

Compile-to-js and compile-to-c language, highly readable, keep it simple philosophy
GNU Affero General Public License v3.0
147 stars 7 forks source link

extraComments option doesn't work #8

Closed jescalan closed 10 years ago

jescalan commented 10 years ago

It looks like you have this option all set up to work fine, but it doesn't actually do anything at the moment.

https://github.com/luciotato/LiteScript/blob/master/lib/Compiler.js#L188

jescalan commented 10 years ago

But I actually need that option, it looks like you just removed it?

luciotato commented 10 years ago

What do you need the option to do? I removed it because It was doing nothing.

If you want to generate js without comments use: {comments:0} (default is 1)

If it was not the case, please tell me.

jescalan commented 10 years ago

I want it to generate js with comments, but without the header that says "compiled with litescript" and the source file

luciotato commented 10 years ago

ok, I've added option extraComments, default 1. when 1, adds "//compiled by" source reference.

jescalan commented 10 years ago

Perfect! That helps a lot.

jescalan commented 10 years ago

Hey, sort of unrelated, but do you have tests at all for this library?

luciotato commented 10 years ago

npm test from main folder. runs: https://github.com/luciotato/LiteScript/blob/master/devel/util/test.js

Specific test for compiler javascript API, see: https://github.com/luciotato/LiteScript/blob/master/devel/util/test-v0.6/require-compiler/compileDir.js

luciotato commented 10 years ago

unrelated also, and maybe not my business, but... are you just testing LiteScript or building some app, or migrating some existing app?

jescalan commented 10 years ago

Really just testing. I like to look into most compiled languages and think about adding adapters for them to accord.