search

lucisgit / moodle-filter_jwplayer

Moodle (<=3.1) filter that allows using JW Player for playing HTML5 and flash content.
https://moodle.org/plugins/view/filter_jwplayer
6 stars 6 forks source link

filter_jwplayer: Prevent return URLs being escaped. #33

Closed owenbarritt closed 9 years ago

owenbarritt commented 9 years ago

The filter is currently escaping the parameters on the URLs as this is the default behaviour when a moodle_url is converted to a string.

This fixes that and also add urldecode() calls to the image and subtitle urls for consistency.

kabalin commented 9 years ago

Hi @owenbarritt Was this causing any issues?

owenbarritt commented 9 years ago

Yes, if the URL of the video had an & in it, it was being escaped to &amp; which was causing issues with the media server I was testing this with not getting the necessary query parameters.

The urldecode bit was just put in for consistency.

kabalin commented 9 years ago

OK, merged, thanks for fixing the issue.