search

lucisgit / moodle-filter_jwplayer

Moodle (<=3.1) filter that allows using JW Player for playing HTML5 and flash content.
https://moodle.org/plugins/view/filter_jwplayer
6 stars 6 forks source link

filter_jwplayer: Update to support JWPlayer 7 #34

Closed owenbarritt closed 9 years ago

owenbarritt commented 9 years ago

Adds CSS custom skin support (XML skins no longer supported by player) Adds mpeg-dash (.mpd) to supported extensions (off by default)

Fixes bug recognising extensions when query string included. i.e. http://example.com/file.ext?query was being recognised as a ext?query extension rather than ext

kabalin commented 9 years ago

Hi @owenbarritt ,thanks for commit. I think there was a good reason not to use core_media::get_extension, but I do not remember now why... I will keep this pull request unmerged for now, but will have a detailed look when preparing a next release.

owenbarritt commented 9 years ago

OK, I've taken that fix out for now and will put it in a separate pull request.

kabalin commented 9 years ago

Please resubmit pull request to JW7 branch, master branch will be deleted as per #37.

owenbarritt commented 9 years ago

Resubmitted for JW7 branch in #39