search

lucisgit / moodle-filter_jwplayer

Moodle (<=3.1) filter that allows using JW Player for playing HTML5 and flash content.
https://moodle.org/plugins/view/filter_jwplayer
6 stars 6 forks source link

Log player events #48

Closed owenbarritt closed 8 years ago

owenbarritt commented 9 years ago

First commit brings existing JS code inline with the JW7 API guidance at http://support.jwplayer.com/customer/portal/articles/1413074-javascript-api-quick-start

Second commit adds support for logging key player events. It creates the events in moodle corresponding to the player events as listed in the commit message.

owenbarritt commented 9 years ago

Coding style for this one should now be fix. Let me know if I've missed anything.

kabalin commented 8 years ago

@owenbarritt can you please rebase this on updated JW7 branch.

Really great feature, thanks for your time!

owenbarritt commented 8 years ago

OK, should be rebased now.

kabalin commented 8 years ago

Great, thanks a lot!

kabalin commented 8 years ago

@owenbarritt do you think that errors need to be recorded in activity log as well? I think browser console debug output should be sufficient for them, unless you need to "debug" remotely that player works on client side.

owenbarritt commented 8 years ago

Yes, as otherwise they only occur locally in the client and there's no record of any issue on the server.

If you are looking at a particular user's interaction with a video, then any errors they hit are part of this so need to be included if you are going to get a full picture. At the end of the day they may be a big reason for a user not watching a particular video.

kabalin commented 8 years ago

@owenbarritt May I ask which version of Moodle are you currently using?

owenbarritt commented 8 years ago

We're currently using 2.9.

This might have been written on 2.7 though.

Is there an issue with this with some version of moodle?

kabalin commented 8 years ago

I have refactored JW7 to use AMD (https://docs.moodle.org/dev/Javascript_Modules, new thing in 2.9), it is much more flexible IMO, will release both JW6 and JW7 hopefully tomorrow or early next week. JW7 will be for Moodle 2.9+ only.

owenbarritt commented 8 years ago

Makes sense, it would need changing sooner or later anyway.