search

lucisgit / moodle-filter_jwplayer

Moodle (<=3.1) filter that allows using JW Player for playing HTML5 and flash content.
https://moodle.org/plugins/view/filter_jwplayer
6 stars 6 forks source link

JW7: Fix code style in issues as per travis CI output. #57

Closed kabalin closed 7 years ago

kabalin commented 8 years ago

There are some issues have been identified, most of them are caused by coding style inconsistencies.

https://travis-ci.org/lucisgit/moodle-filter_jwplayer/branches

There is a way to run same tests locally using moodle-plugin-ci installed using composer. Alternatively just use codechecker script which is identifying issues above.

kabalin commented 8 years ago

Most errors are addressed in https://github.com/lucisgit/moodle-filter_jwplayer/commit/f788c25fa9619f24cabd0ed422d99e15d44b29b0.

Issue with amd properties has been reported: https://tracker.moodle.org/browse/CONTRIB-6175

kabalin commented 8 years ago

Moving to milestone 7-0.6

kabalin commented 7 years ago

Plugin is no longer maintained, use https://github.com/lucisgit/moodle-media_jwplayer for Moodle 3.2 onwards.