search

lucko / commodore

Utility for using Minecraft's 1.13 'brigadier' library in Bukkit plugins.
MIT License
176 stars 15 forks source link

Using commodore makes commands not usable with command blocks #15

Open marcbal opened 4 years ago

marcbal commented 4 years ago

When declaring a command in commodore, the command does not execute anymore in a command block, but still does work in chat.

A possible fix, like the current code do with setCustomSuggestionProvider, is to set the executes property of each command node to the instance of BukkitCommandWrapper (that also implements com.mojang.brigadier.Command). I already tried that by manually doing it on a specific command, and it works properly now.

It seems that the execution of the command blocs is directly parsed with the vanilla CommandDispatcher of the server, instead of being parsed by the Bukkit command dispatcher.

lucko commented 2 years ago

Might be fixed by 7bbcbe4f4722d5b670a074a0995bf24633d03885

could you re-test?

marcbal commented 2 years ago

I'm not using commodore since a long time now :/ Maybe someone else is able to test?

lucko commented 2 years ago

No worries 😄

Didn't realise how old this issue was - sorry I didn't get around to looking sooner.