search

lucko / commodore

Utility for using Minecraft's 1.13 'brigadier' library in Bukkit plugins.
MIT License
176 stars 15 forks source link

Parameter hints when defocusing the tab suggestion box no longer appear without typing a character #29

Open WiIIiam278 opened 2 years ago

WiIIiam278 commented 2 years ago

The "hints" that appear indicating expected command arguments when you press escape to exit the box with tab suggestions no longer seem to appear as of 1.19 / new commodore versions. This affects LuckPerms, too.

Reproduce (using LP as an example, though you can use this library in another project and experience the same results).

  1. Fire up a server with the latest Luckperms running Paper (supporting commodore 2.1+)
  2. Type /luckperms user player permission set
  3. You will be presented with a list of tab suggestions. Press ESC to exit the window
  4. You should see the remaining parameters to enter on the command. Instead, you see an (incorrect) syntax error.

Example of this occurring with my plugin. Here, I've pressed ESC and expect the field name I am on "name" to appear as a hint; [<name>] image

Expected result, with LuckPerms: image

Actual result (Commodore 2.2 / Paper 69950d5 / Minecraft 1.19.1): image

However, parameter hints will appear if you type a character into the field work. image

This does not mirror Vanilla behavior, where hints are able to display even before typing a character. image

Thank you for your work!

CyberedCake commented 2 years ago

I'm pretty sure this has been an issue for a while now, as I remember this being a problem in 1.18, unless I am misremembering something.