lucko / commodore

Utility for using Minecraft's 1.13 'brigadier' library in Bukkit plugins.
MIT License
176 stars 15 forks source link

Clarify Spigot support #30

Open 0dinD opened 2 years ago

0dinD commented 2 years ago

From the recent commits and a quick look at the Discord server, I take it that Spigot support has been dropped for Minecraft >= 1.19? I have no issues with this really, I totally understand the maintenance burden involved. But either way, I feel like it makes sense to document this somewhere, in the README for example.

CyberedCake commented 2 years ago

Edit: You can ignore this reply, I seem to of misunderstood the post. Sorry about that.

Click to view original post ### Um, I'm not entirely sure what you mean, using `'me.lucko:commodore:2.2'` on a Purpur 1.19.2 server, I get full Commodore support, see below: ![image](https://user-images.githubusercontent.com/61170080/187040931-423dd786-7f26-4b6f-acf7-4b48ea256518.png) --- ![image](https://user-images.githubusercontent.com/61170080/187040938-12cc0186-dc6b-44d2-987d-c289fa0a7379.png) --- ![image](https://user-images.githubusercontent.com/61170080/187040968-1d297cd4-2da9-4eab-acbe-e17efe5b7b20.png) --- Version: ``` > ver [13:15:54 INFO]: Current: git-Purpur-1762 (MC: 1.19.2)* [13:15:54 INFO]: * You are 6 version(s) behind [13:15:54 INFO]: Download the new version at: https://purpurmc.org/downloads ```
0dinD commented 2 years ago

Well yes, because you're using Purpur, not Spigot. My point was that Commodore seems to support only Paper (and derivatives like Purpur), not Spigot, as of Minecraft 1.19.

Which, again, I have no issues with personally. But since some people using my plugin are still using Spigot, not Paper, I may need to inform them about the fact that they won't get proper command completion on 1.19+.