lucko / helper

A collection of utilities and extended APIs to support the rapid and easy development of Bukkit plugins.
MIT License
456 stars 87 forks source link

Fix clickable holograms for BukkitHologramFactory #75

Closed FerusGrim closed 4 years ago

FerusGrim commented 4 years ago

Holograms which use HologramFactory (which, by default, delegates to the BukkitHologramFactory), stopped working at some point. The issue seems to be that Bukkit/Spigot no longer fires the requisite events on invisible ArmorStand objects.

My fix for this is simple: When a Hologram is clickable, spawn Pigs as passenger for the ArmorStands, and listen to those, instead.

From all the testing I've done, I also believe that IndividualHologramFactory is no longer working, as well. However, given this relies on packets and packet listening, rather than events, I'm honestly not entirely certain why this would be and am much more hesitant to work on a fix for it. Additionally, given I don't use it, I have very little motivation, for which I apologize.

If anyone wants to tackle that, please feel free.

lucko commented 4 years ago

Looks great, thanks