lucko / spark

A performance profiler for Minecraft clients, servers, and proxies.
https://spark.lucko.me/
GNU General Public License v3.0
1.02k stars 140 forks source link

Unable to use sparkc or sparkclient commands #381

Open Mr-LemonLime opened 8 months ago

Mr-LemonLime commented 8 months ago

Description

I am unable to any sparkc or sparkclient but can use spark just fine.

Reproduction Steps

go into minecraft 1.18.2 and type /sparkc profiler start or /sparkclient profiler start, nothing will be outputted in console, logs or chat. but /spark profiler open works just fine. Same issue is for any other sparkc and sparkclient commands

Expected Behaviour

to start the command as expected, similar to the manner of /spark profiler open

Platform Information

Spark Version

v1.10.38

Logs and Configs

https://mclo.gs/MBX8gOF

Extra Details

No response

BrangGit commented 7 months ago

Same here on 1.18.2 / forge 40.2.13. Downgrading Spark from 1.10.38 to 1.9.11 fixes the issue.

[22Jan2024 02:11:25.247] [Server thread/DEBUG] [net.minecraftforge.common.ForgeHooks/WP]: Gathering id map for writing to world save sparkc profiler memory test
[22Jan2024 02:11:25.278] [Server thread/DEBUG] [net.minecraftforge.common.ForgeHooks/WP]: ID Map collection complete sparkc profiler memory test
[22Jan2024 02:11:27.989] [ForkJoinPool.commonPool-worker-17/ERROR] [net.minecraftforge.eventbus.EventSubclassTransformer/EVENTBUS]: Could not find parent me/lucko/spark/lib/protobuf/GeneratedMessageLite for class me/lucko/spark/proto/SparkWebSocketProtos$RawPacket in classloader jdk.internal.loader.ClassLoaders$AppClassLoader@73d16e93 on thread Thread[ForkJoinPool.commonPool-worker-17,10,main]
[22Jan2024 02:11:27.989] [ForkJoinPool.commonPool-worker-17/ERROR] [net.minecraftforge.eventbus.EventSubclassTransformer/EVENTBUS]: An error occurred building event handler
java.lang.ClassNotFoundException: me.lucko.spark.lib.protobuf.GeneratedMessageLite
    at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]

Logs : debug.log

skadlig commented 3 months ago

Same here on 1.18.2 / forge 40.2.13. Downgrading Spark from 1.10.38 to 1.9.11 fixes the issue.

This solved the issue for me as well. So there must be something in newest release that breaks the mod. Perhaps just for linux since it doesnt work for me on Pop Os but do work for my son on windows 11.

Tidy-Bear commented 3 months ago

https://github.com/lucko/spark/blob/8b6c26636b19464e43f99ab17b6059de7ad436a5/spark-forge/src/main/java/me/lucko/spark/forge/plugin/ForgeClientSparkPlugin.java#L86-L94

https://github.com/lucko/spark/blob/8b6c26636b19464e43f99ab17b6059de7ad436a5/spark-forge/src/main/java/me/lucko/spark/forge/plugin/ForgeSparkPlugin.java#L164-L168

The return value of context.getInput() has preceding slash in MC 1.18, but being trimmed above MC 1.19.

Wolfizen commented 1 week ago

Same here on 1.18.2 / forge 40.2.13. Downgrading Spark from 1.10.38 to 1.9.11 fixes the issue.

Downgrading from spark 1.10.38 to spark 1.9.11 on MC 1.18.2 + Forge 40.2.17 also fixed this issue for me.