BUG! VideoPlayer.hx, WebmPlayer.SKIP_STEP_LIMIT is not static variable for GWebDev's extension-webm

[JOELwindows7]

this issue has duplicates? Black textures - https://github.com/luckydog7/Funkin-android/issues/12 (max texture size problem) Crash - https://github.com/luckydog7/Funkin-android/issues/10 (ram problem)

Describe the bug Compilation error on VideoPlayer.hx Line 58 (WebmPlayer.SKIP_STEP_LIMIT = SKIP_STEP_LIMIT;).

To Reproduce Steps to reproduce the behavior:

1. Clone this source code
2. get GWebDev's extension webm by haxelib git extension-webm https://github.com/GrowtopiaFli/extension-webm
3. rebuild the android library of that with lime rebuild extension-webm android
4. that's it, go this directory of where you cloned this repo cd ~/whateverFolder/Funkin-android e.g.
5. lime test android and wait
6. see error

Expected behavior Compilation works and app runs.

Screenshots If applicable, add screenshots to help explain your problem.

damn, lost the terminal as I've already worked around it.

Additional context Possible Solutions:

• Make sure to fully copy GWebDev's Video cutscener kit https://github.com/GWebDevFNF/openfl-haxeflixel-video-code and use through here. These files adds most importantly GlobalVideo.hx that choose either native webm player or HTML5's webm player depending on your platform you are compiling to. Optimize the system to conform with this Video cutscener kit and to change Skip step limit, you must refer through instance instead of static with e.g. GlobalVideo.getWebm().webm.SKIP_STEP_LIMIT = SKIP_STEP_LIMIT;. example of utilization found here (find function backgroundVideo()), you see that I reference .

Workaround, either:

• disable SKIP_STEP_LIMIT reference at VideoPlayer.hx around line 58 so that from here

  ...
  public function new(asset:String, ?x:Float, ?y:Float) 
  {
      super(x, y);
  
      #if cpp
      WebmPlayer.SKIP_STEP_LIMIT = SKIP_STEP_LIMIT;
  
      webm = new WebmPlayer();
  
      changeVideo(asset);
  ...

  now looks like

  ...
  public function new(asset:String, ?x:Float, ?y:Float) 
  {
      super(x, y);
  
      #if cpp
      //WebmPlayer.SKIP_STEP_LIMIT = SKIP_STEP_LIMIT;
  
      webm = new WebmPlayer();
  
      changeVideo(asset);
  ...

  Though this may cause video to offsync since the Skip step limit left unchanged.

• use KadeDev's version of extension-webm. If you already have installed extension-webm, uninstall the library first with haxelib remove extension-webm. Now install KadeDev version with haxelib git extension-webm https://github.com/KadeDev/extension-webm. That's it. you do not have to change the code especially the WebmPlayer.SKIP_STEP_LIMIT = SKIP_STEP_LIMIT; thingy in VideoPlayer.hx since the SKIP_STEP_LIMIT variable itself is static in KadeDev version.

[JOELwindows7]

wait. I can just

webm = new WebmPlayer();
webm.SKIP_STEP_LIMIT = SKIP_STEP_LIMIT;

stuff like that.

[KlavierGayming]

R e a d t h e f u c k i n g b u i l d i n s t r u c t i o n s

[JOELwindows7]

R e a d t h e f u c k i n g b u i l d i n s t r u c t i o n s

i

did

well before the suggestion to use new instruction.