search

luckyframework / carbon_sendgrid_adapter

MIT License
1 stars 2 forks source link

Simplify usage with SendGrid as an Heroku Addon #1

Closed hfjallemark closed 3 years ago

hfjallemark commented 6 years ago

Send grid requires SEND_GRID_KEY by default but the Heroku addon adds the following config vars: SENDGRID_PASSWORD and SENDGRID_USER which requires me to manually add a KEY too. Not a high priority but would be nice if it could work out of the box with Heroku.

jwoertink commented 3 years ago

Yeah, that's a good idea. Thanks for the suggestion!

ghost commented 3 years ago

@jwoertink I'd like to work on this if no one has started yet 👍🏻

jwoertink commented 3 years ago

@Liberatys sure thing! That would be awesome.

ghost commented 3 years ago

https://docs.sendgrid.com/for-developers/sending-email/authentication#basic-authentication - 😆 I should have read the entire page before implementing it 😆

To ensure the security of your account, Twilio SendGrid has ended support for basic authentication with username and password as of Q4 2020.

jwoertink commented 3 years ago

oh LOL :rofl: Yup. I just saw that too. I left a comment, but it looks like the answer here is that it's probably not an issue. The Heroku addon has most likely been updated to fully support the new way... I'm leaning towards we just close this out. What do you think @Liberatys ?

ghost commented 3 years ago

@jwoertink sure thing 👍🏻 no point in supporting something that is deprecated by the 'vendor' 😆

jwoertink commented 3 years ago

Cool. Thanks for taking it on anyway! Still closes out the issue :grimacing:

@hfjallemark Sorry it took so long to get around to this. Hopefully it is easier with Heroku at this point :joy: