search

luckyframework / dexter

A logger with maximum customizability and surgical precision
MIT License
21 stars 4 forks source link

Upgrade to Crystal 0.35.0 #30

Closed bcardiff closed 4 years ago

bcardiff commented 4 years ago

These are some of the changes I've notice to upgrade to Crystal 0.35.

Probably the local data of log entries can be redesigned to avoid intermediate structures. For now I was focused on make the spec pass.

Feel free to close the PR and use it as input for a cleaner migration.

If only crystal 0.35.0 is wanted, the compare_versions(Crystal::VERSION, "0.35.0-0") can be dropped and the crystal property in shard.yml should be updated.

paulcsmith commented 4 years ago

Thanks @bcardiff! This was used as a base for #31