search

luckyframework / lucky

A full-featured Crystal web framework that catches bugs for you, runs incredibly fast, and helps you write code that lasts.
https://luckyframework.org
MIT License
2.59k stars 156 forks source link

Improve error message creating route links #1639

Closed matthewmcgarvey closed 2 years ago

matthewmcgarvey commented 2 years ago

Resolves #1637

Check out the connected issue for screenshots. Instead of removing Lucky::Action.with, I set up the function to require the expected arguments the same way as Lucky::Action.route which then calls route with them. This means it is not a breaking change.

I did remove the compiler error if you call Lucky::Action.with with no arguments. You get an error that doesn't actually point you to where you called it.

matthewmcgarvey commented 2 years ago

@jwoertink Yep, the only functionality removed was the custom error we had if you called .with with no args.